Repository navigation
feat(normalizer): add Brazilian Portuguese normalization - #553
Merged
remsky merged 7 commits intoNov 13, 2026
Merged
Conversation
Owner
|
Hey @Udbhav-regadamilli, thanks for this. A few things before it can go in:
|
Udbhav-regadamilli
force-pushed
the
codex/portuguese-normalization
branch
from
November 4, 2026 18:21
52484be to
47c601e
Compare
Contributor
Author
|
Hi @remsky, I have made the relevant changes; please check them once. |
Contributor
Author
|
Hi @remsky, just following up on this PR. I’ve pushed the requested changes, and the latest checks are green. When you have a chance, could you please take another look? Happy to make any further adjustments. Thanks! |
Owner
|
Hey @Udbhav-regadamilli, thanks for the patience! That covers everything from my last pass. Think there's a few cases and rules that'll need some follow-ups/feedback from native speakers e.g some numbers before feminine nouns like |
This was referenced Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pand add focused regression cases.Closes #392
Validation
py_compilepassed for the implementation and test module.