Repository navigation
Conversation
Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
The relay-count check that ran in `tearDown()` moved to a small `AfterEachTest` interceptor: a failing `#[AfterTest]` hook in Testo only writes to stderr and leaves the test green. Infection is dropped from require-dev: the Testo adapter needs Infection 0.33+, which requires PHP 8.3. `infection.json.dist` targets Testo, so the Infection Phar (bundles the adapter) keeps `composer test-mutations` working. Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (18)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 What was changed
"php": ">=8.2").phpunit/phpunitandphpunit.xmlare gone,testo.phpdeclares a singleUnitsuite overtests/Goridge,composer test/composer test-covercalltesto. No mocking library was needed — the suite has no mocks.spiral/gh-actions/.github/workflows/testo.yml@master(feat(testo): test PHP 8.2-8.6 by default, add test-server input spiral/gh-actions#10) withtest-server: trueanddependencies: ["lowest","highest"], so the PHP matrix is the workflow default 8.2–8.6.vimeo/psalmis widened to^6 || ^7. Infection is removed from require-dev: the Testo adapter needs Infection 0.33+, which requires PHP 8.3;infection.json.distnow targets Testo, so the Infection Phar (it bundles the adapter) keepscomposer test-mutationsworking.Review notes
#[AfterTest]hook in Testo does not fail the test (it only goes to stderr). TheMultiRPCrelay-leak check fromtearDown()therefore runs through a smallAfterEachTestinterceptor intests/Goridge/Support, which fails the test like PHPUnit did.#[ExpectException]on a baseMultiRPCtest also applies to theMsgPackMultiRPCTestoverride. The overridden base tests keepExpect::exception()in the body.testHandleRelayDisconnectWithPressureForceUndiscoveredcalledexpectException()twice; PHPUnit keeps only the last one, Testo checks both. The dead first expectation was dropped.Checklist
MsgpackCodec(withoutext-msgpacktherybakit/msgpackfallback always throws — a missingreturn); the fix is not part of this PR