Repository navigation
Leave phone click navigation to the website and browser - #111
Conversation
Requested in item 5: prevent unwanted telephone navigation from analytics callbacks while retaining default outbound, email, download, and phone collection when data-collect is omitted. Refs #107
Documentation update
|
Claude review checkpointReviewed commit |
|
SDLC label: |
|
In response to #111 (comment): Prepared a patch against current docs/master adding the Phones section, correcting the default data-collect list, and describing native phone-link navigation. Verified phones are enabled by default and the v12 fix leaves navigation to the browser and site handlers. The patch applies cleanly. There is no matching open docs PR to update. I have requested owner approval for a supporting docs PR because this automation is authorized to push to existing PR branches. Publication of these instructions must follow the relevant script PR and the v12 release; the patch remains local pending that approval. |
Requested: rebuild the distributions after PR #108 and verify that manual queries override browser parameters, absent manual queries fall back to location.search, and existing filtering remains effective. Include the newly merged phone-click fix from #111 and preserve current inline events. Regenerate only the 29 affected bundles and source maps. All 39 unit tests and 24 additional payload checks pass on the pinned toolchain. Refs #107
Base: #40 (
v12). Merge this intov12before releasing #40 tomain.Summary
Fixes #107
Keep collecting phone clicks while leaving telephone-link navigation to the browser and the website's click handler. The analytics callback no longer assigns document.location for phone events, including when the click was cancelled.
Requested in compatibility review item 5. Omitting data-collect still enables outbound, email, download, and phone collection. Existing explicit selections and other link types keep their behavior.
Security implications
Testing
git diff --checkpassed.auto-events.js: +13 bytes; gzip +2 bytes, excluding generated headers. Main tracker unchanged.mainrefreshed through the broker and already included in this branch.Checklist