Repository navigation
refactor: create the route-root owner with createRoot, not createOwner - #711
Merged
Merged
Conversation
Since solid#4444 the public `createOwner` binds `dispose` on every owner it returns. The router's route-root owner is only ever disposed with its component, so `createRoot(() => getOwner())` gives the same owner (same parent, same hydration id counter) without pulling the bind into router pages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2
🦋 Changeset detectedLatest commit: 774617a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ryansolid
changed the title
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: the router creates its route-root owner with
createOwner()fromsolid-js. solidjs/solid#4515 takescreateOwnerout of solid-js's public types (it becomes typed only throughsolid-js/internal; 1.x had nocreateOwner), so this import stops type-checking once the router builds against a solid-js with that change.After: the router gets the same owner from
createRoot(() => getOwner()!). It has the same parent and the same hydration id counter, and it is disposed with the component. It uses only public API.How: I measured on solid's size scenarios, over solid#4515, building the router's
nextwith and without this change:The brotli drop is mostly layout. The real cost is the 7 B minified for
createRootplus thegetOwnercall. Router tests pass: 728 client tests, 105 server tests, andtest:types. It works on asolid-jswith or without #4515, so it can merge before or after.🤖 Generated with Claude Code
https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2