Skip to content

refactor: create the route-root owner with createRoot, not createOwner #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryansolid merged 2 commits into from
Oct 31, 2026
+10 −2
Merged

refactor: create the route-root owner with createRoot, not createOwner #711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9997aa
perf: create the route-root owner with createRoot, not createOwner
claude Oct 30, 2026
774617a
chore: reword the changeset for solid#4515
claude Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/route-owner-create-root.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@solidjs/router": patch
---

The router's route-root owner now comes from `createRoot(() => getOwner())` instead of `createOwner()`. `createOwner` is leaving solid-js's public types (solid#4515, typed only through `solid-js/internal`), and this uses only public API with the same parent, hydration ids and disposal.
7 changes: 5 additions & 2 deletions src/routers/components.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ import type {Component} from "solid-js";
import type {JSX} from "@solidjs/web";
import {
createMemo,
createOwner,
createRoot,
getOwner,
onCleanup,
runWithOwner,
untrack,
Expand Down Expand Up @@ -100,7 +100,10 @@ export function Routes(props: { routerState: RouterContext; branches: () => Bran
// dedicated one, created before the memo: the roots draw hydration ids from
// its counter, so the ids don't depend on whether the memo first parked on
// a lazy subtree (the server's render can park where the client's doesn't).
const owner = createOwner();
// `createRoot` hands back the same kind of owner `createOwner` would, minus
// the bound `dispose` the public `createOwner` pays for (solid#4444): this
// owner is only ever disposed with the component.
const owner = createRoot(() => getOwner()!);

const routeStates = createMemo((prev: RouteContext[] | undefined) => {
// While a lazy subtree resolves, `matches()` is not ready and this
Expand Down
Loading