Repository navigation
fix: keep build metadata out of the client output in app builds - #518
Merged
Merged
Conversation
When one process builds both environments, the server build reads Vite's manifest and the server-function data from memory. The plugin then removes the manifest it turned on (an app's own build.manifest stays) and moves .vite/solid-server-functions.json beside the server bundle, so hosts that publish the client output, like Nitro, don't serve them.
🦋 Changeset detectedLatest commit: 764b37d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
birkskyum
added a commit
that referenced
this pull request
Oct 31, 2026
…mory (#519) Since #514 and #518, a server build in the same process as the client build reads the build id, the server-function modules and Vite's manifest from memory. The recorded client output directory could then only lead to a stale file, so readers fall back to the configured outDir and the dist/client convention only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #511 (#511 (comment)): under Nitro the client build writes into the public directory, so
/.vite/manifest.jsonand/.vite/solid-server-functions.jsonwere served. When one process builds both environments, the server now reads both from memory, the plugin removes the manifest it turned on (setbuild.manifestto keep it), and the server-function file moves to the server output. Separatevite build/vite build --ssrruns are unchanged.