Skip to content

feat(han-planning): add reassess-approach and hand off at the round cap - #231

Merged
mxriverlynn merged 1 commit into
testdouble:v6.0.0-betafrom
taminomara:worktree-reassess-approach
Oct 27, 2026
Merged

mxriverlynn merged 1 commit into
testdouble:v6.0.0-betafrom
taminomara:worktree-reassess-approach

Conversation

@taminomara

@taminomara taminomara commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Han's review loops could only say "this finding, this fix". A plan that kept drawing edge-case findings on one mechanism ran to its round cap while being patched, and nothing ever asked whether a different tool or shape would make the whole class of findings moot. The investigation behind this change is in docs/plans/review-loop-approach-reassessment/investigation.md.

This PR adds /reassess-approach to han-planning. It gathers a plan or code unit, the findings it has absorbed, and the reason it is being asked, then dispatches one han-core:software-architect critic in a fresh context with only that material. The critic returns structurally different alternatives, always including "stop doing this" and "continue as is", each citing the recorded findings it would make moot, what it adds and removes in owned code paths or plan items, and what to run next. The skill writes one options report and changes nothing; the decision comes back to the person as one question.

/iterative-plan-review (team mode) and /plan-implementation (medium and large) invoke it when they reach their round cap without converging, record the result as an approach finding or ledger tag, and present the options through their existing question channel. Small runs, capped at one round, do not hand off: one pass cannot tell a plan stuck on its approach from a plan that needed edits, so they end with a one-line pointer to the skill instead. The skill is also invocable by hand on any plan or code path.

Key file changes

  • han-planning/skills/reassess-approach/SKILL.md and references/approach-reassessment-template.md: the new skill and its report template.
  • han-planning/skills/iterative-plan-review/SKILL.md: approach as a major category, the team-mode hand-off at the cap, the lightweight pointer, and the closing-question wording. references/review-findings-template.md gains the category and an Alternatives: field.
  • han-planning/skills/plan-implementation/SKILL.md and references/round-aggregation.md: the facilitation-plateau note becomes the hand-off at medium and large, with an approach ledger tag.
  • han-planning/skills/plan-a-change/SKILL.md: reverse boundary clause so disambiguation runs both ways.
  • han-planning/docs/skills/reassess-approach.md, plugin README, skills index, docs/workflows.md, docs/concepts.md, docs/readability.md, docs/yagni.md, docs/evidence.md, CLAUDE.md, CONTRIBUTING.md, and the software-architect agent doc: documentation and catalog coverage.
  • evals/reassess-approach/: five trigger tests and one functional test over a scaffold with a hand-written regex parser, a plan that commits to it, and three rounds of clustered edge-case findings.

Plugin versions and CHANGELOG.md are untouched. Manifest descriptions list the new skill.

Test Plan

  • npm run lint passes on every tracked file touched; a direct prettier --check passes on the new files.
  • npm test: the suite could not complete in the authoring sandbox (its temp directory is unwritable). The branch changes no shell script or .bats file, and the suite passed 121/121 on this branch before the final Markdown-only edits. Please run it once locally.
  • Run the evals/reassess-approach suite. The functional case is the first measurement of whether the critic's alternatives are structurally different rather than nearby variants.
  • Run /iterative-plan-review large over a plan whose findings file is at the cap and confirm the closing question carries the options.

🤖 Generated with Claude Code

Han's review loops could only say 'this finding, this fix'. A plan that kept drawing edge-case findings on one mechanism ran to its round cap while being patched, and nothing asked whether a different tool or shape would make the whole class of findings moot. The investigation is in docs/plans/review-loop-approach-reassessment/investigation.md.

Add /reassess-approach: it gathers a plan or code unit, its recorded findings, and the reason it is asked, dispatches one han-core:software-architect critic in a fresh context, and returns structurally different alternatives, always including stop and continue, as one options report and one question. iterative-plan-review (team mode) and plan-implementation (medium and large) invoke it at their round cap when the convergence condition still fails; small runs end with a pointer instead. Docs, catalogs, and an eval suite with a regex-parser fixture are included. Plugin versions and the changelog are untouched.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@taminomara
taminomara force-pushed the worktree-reassess-approach branch from cbb6db3 to 73d92fe Compare October 23, 2026 23:02
@taminomara
taminomara marked this pull request as ready for review October 23, 2026 23:02
@taminomara

Copy link
Copy Markdown
Contributor Author

This PR attempts to stop agents from parsing HTML with regexs™. Note, I didn't run skillwalker evals even though an agent generated them for the new skill. I did try it on the original review thread that prompted its creation, and while my preferred approach got YAGNIed (fair-ish), it did steer the plan towards a more sane solution.

taminomara added a commit to taminomara/han that referenced this pull request Oct 24, 2026
…und cap

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

# Conflicts:
#	CLAUDE.md
@mxriverlynn

Copy link
Copy Markdown
Collaborator

love it! thank you :)

@mxriverlynn
mxriverlynn changed the base branch from main to v6.0.0-beta October 27, 2026 14:53
@mxriverlynn
mxriverlynn merged commit 2838a9b into testdouble:v6.0.0-beta Oct 27, 2026
2 checks passed
@mxriverlynn mxriverlynn mentioned this pull request Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants