Repository navigation
Feature/go client - #33
Merged
Merged
Conversation
Add a new `xbot_service_interface_go` package implementing a Go client for the xbot wire protocol (discovery, claim, RPC calls, and DATA messages) without code generation or cgo, depending only on fxamacker/cbor. Includes heatshrink compression support, typed argument helpers, and comprehensive tests. Add a GitHub Actions workflow to run gofmt, go vet, race-enabled tests, and build checks on the Go package, and update the Readme with Go Interface usage documentation.
Add documentation for the new `xbot-codegen` command across the root Readme, codegen README, and Go module README, explaining how to generate typed clients from a service.json, the `-service-id` option, CI sync workflow, and current limitations (outputs, non-scalar arrays).
- Generate slice types and pack/decode helpers for non-uint8 fixed-size arrays instead of erroring out - Emit ExpectedType/Version so generated clients reject services announcing an incompatible schema - Create the output directory when running under go:generate - Only emit the numeric array helpers the generated file needs - Document new options and ErrIncompatibleService in README
|
Caution Review failedThe pull request is closed. Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Both the Python and Go generators now fail early with a clear error when an enum has an empty values map. Previously the to_string path attempted to derive a member count from max(values), causing an opaque ValueError during code emission. A test case is added to cover the Go validator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes #32