Conversation
Signed-off-by: minleejae <mmj9808@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON_TABLE rejects
n INT PATH '$.n' DEFAULT '9' ON ERROR, including otherwise valid CREATE TABLE AS queries. Parse column ON EMPTY and ON ERROR with one shared response production, adding DEFAULT to the error path.The response production reuses the existing JSON_QUERY alternatives and adds DEFAULT expressions. This removes duplicate response parsing while retaining the generated parser's existing JsonTableOnEmptyBehavior entry point. Defaults remain typed expressions accessible through getOnErrorBehavior(), its expression setter, and ExpressionVisitorAdapter. Original clause order is retained, including the legacy ON ERROR-before-ON EMPTY spelling.
Validation:
./gradlew checkpassed (8,157 tests, 25 skipped). Regression tests cover nested columns, both clause orders, AST edits and visitor traversal, both renderers, reparsing, and existing non-default responses. Six reproductions were executed on MySQL 8.4.11 before and after rendering, with identical results. Existing Oracle parser tests also pass.Reference: MySQL JSON_TABLE response clauses.
Combined validation with #2682, #2683, #2684, #2685 and #2686: all five changes merge without conflicts; the integrated
./gradlew checkpasses (8,190 tests, 25 skipped). All 254 MySQL 8.4.11 fixtures parse, render and reparse, and execute with results identical to the original SQL.