Conversation
Signed-off-by: minleejae <mmj9808@gmail.com>
This was referenced Sep 23, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lexer includes trailing spaces in quoted hex tokens. For
SELECT X'6162' AS v, HexValue.getDigits() consequently includes a quote, getLong() throws, and each parse/render cycle adds whitespace. JSON_VALUE DEFAULT expressions and generated columns have the same problem.Factor the quoted segment into a private lexer fragment and allow separating spaces only when followed by another quoted segment. S_HEX now ends at its final quote. Existing hex spellings and legacy segmented forms remain accepted; the public HexValue API is unchanged.
Validation:
./gradlew checkpassed. Tests cover numeric/string/blob accessors, whitespace before aliases and FROM, repeated round trips, existing token forms, and editing a JSON_VALUE default through the AST. Five reproductions were executed on MySQL 8.4.11 before and after rendering, with identical results. This fixes token boundaries and AST stability; the original SQL was already executable in MySQL.Combined validation with #2682, #2683, #2684, #2685 and #2686: all five changes merge without conflicts; the integrated
./gradlew checkpasses (8,190 tests, 25 skipped). All 254 MySQL 8.4.11 fixtures parse, render and reparse, and execute with results identical to the original SQL.