Conversation
Signed-off-by: minleejae <mmj9808@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MySQL accepts
CAST('ab' AS CHAR(10) ASCII)andJSON_VALUE(j, '$.v' RETURNING CHAR(10) UNICODE), including generated-column expressions. These currently fail in ColDataType. Recognize the shorthand attributes when Dialect.MYSQL is selected, without reserving new keywords.Refactor character-set spelling into ColDataType.CharacterSetSyntax (CHARACTER_SET, CHARSET, ASCII, UNICODE), retaining the existing isUseCharsetKeyword()/setUseCharsetKeyword() API. getCharacterSet() exposes latin1 for ASCII and ucs2 for UNICODE, while rendering preserves the shorthand. Updating the character set switches a shorthand to an explicit clause; equality and hashing include the spelling.
Example:
Validation:
./gradlew checkpassed. Tests cover CAST, JSON_VALUE, generated and ordinary columns, construction and edits, equality, dialect boundaries, legacy CHARSET methods, both renderers and reparsing. Ten reproductions were executed on MySQL 8.4.11 before and after rendering, with identical results.Reference: MySQL character-set shorthand in CAST.
Combined validation with #2682, #2683, #2684, #2685 and #2686: all five changes merge without conflicts; the integrated
./gradlew checkpasses (8,190 tests, 25 skipped). All 254 MySQL 8.4.11 fixtures parse, render and reparse, and execute with results identical to the original SQL.