Repository navigation
Expose replay progress, committed spool loss and worker metrics - #95
Merged
Merged
Conversation
This was referenced Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked after #94. Merge in order #94, #95, #96, #97, #98, #99. This diff contains only this finding relative to its base.
Expose durable ingest replay progress and explicit loss counters for disk segments, torn tails, invalid payloads and corrupt object-store frames. Count losses only after removal/commit so retried reads do not inflate loss, keep partial replays distinct from full success, and record replay insert/ack errors, latency and backlog independently of the stats writer. Disk deletion failures retain backlog and corruption discards no longer inflate the committed-segment counter.
Drain-only workers now expose GET /metrics on RUSH_WORKER_METRICS_ADDR (default 0.0.0.0:9090, explicitly empty disables). The listener binds before worker startup and stays available throughout draining. Only fixed backend/outcome/reason/operation labels are emitted.
Validation: full library suite passed (790 passed, 14 integration tests ignored); final spool-focused suite passed (22 passed, 1 ignored). New regressions cover retry-safe torn-tail accounting, object corruption, partial replay, and worker scraping through shutdown. cargo fmt --check, git diff --check and cargo clippy --all-targets passed; strict -D warnings is blocked by existing repository warnings.