Repository navigation
Expose failed rule evaluations and standalone engine health - #97
Merged
Merged
Conversation
This was referenced Nov 15, 2026
This was referenced Nov 15, 2026
mzupan
force-pushed
the
codex/engine-evaluation-health
branch
from
November 15, 2026 22:45
0478998 to
d0f02a4
Compare
mzupan
force-pushed
the
codex/engine-evaluation-health
branch
from
November 15, 2026 22:45
d0f02a4 to
f116248
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked after #96. Merge in order #94, #95, #96, #97, #98, #99. This diff contains only this finding relative to its base.
Monitor and detection cycles could report success after individual evaluations failed or were rejected. Record per-evaluation success, no-data, errors, rejected admission and cancellation across monitors, detections, SLOs and anomalies. Add due/inflight gauges, duration and last-success timestamps; fail degraded monitor/detection/anomaly cycles while retaining their existing state and notification behavior. Anomaly evaluation-log persistence failures are also counted.
The standalone anomaly worker exports the shared registry and process metrics through GET /metrics on RUSH_WORKER_METRICS_ADDR (default 0.0.0.0:9090; explicitly empty disables). Only fixed engine/outcome labels are emitted, and cancelled work releases inflight gauges without advancing success.
Validation: engine-focused suite passed (67 passed, 2 isolated ClickHouse tests ignored), including new cancellation and bounded-label regressions; final engine-metrics tests passed. cargo fmt --check, git diff --check and cargo clippy --all-targets passed. Strict -D warnings remains blocked by existing warnings. The worker listener is shared with the replay-health change earlier in this stack.