Repository navigation
Measure export body completion, errors and cancellation - #99
Merged
Merged
Conversation
This was referenced Nov 15, 2026
mzupan
changed the base branch from
main
to
codex/notification-delivery-health
November 15, 2026 22:06
mzupan
force-pushed
the
codex/export-stream-health
branch
3 times, most recently
from
November 15, 2026 22:45
e7b7909 to
34cdd51
Compare
mzupan
force-pushed
the
codex/export-stream-health
branch
from
November 15, 2026 22:48
34cdd51 to
80c299d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked after #98. Merge in order #94, #95, #96, #97, #98, #99. This diff contains only this finding relative to its base.
Export handlers previously counted completion when response headers were ready, before a body could fail or time out. Mark export headers as response_ready and measure body EOF, errors, timeout and cancellation separately, with inflight, bytes and duration. Background artifact bodies use a separate fixed kind so their work is distinguishable from HTTP downloads. Serialized-row histograms cover both CSV/JSON generation, with buckets spanning the supported row/byte/time limits.
Body errors/timeouts release admission and drop the cursor immediately, even if a consumer retains the failed body. Add an explicitly named HTTP header-latency metric while retaining the existing metric, and normalize unknown HTTP methods to OTHER to prevent unbounded metric labels. Existing export/job/audit behavior is preserved.
Validation: library suite passed (789 passed, 14 isolated integration tests ignored), final governor tests passed (12/12), API binary tests passed (53/53). New regressions cover EOF/error/timeout/cancellation, immediate cursor release, artifact separation, actual serialized rows and method-label bounds. cargo fmt --check, git diff --check and cargo clippy --all-targets passed. Strict -D warnings is blocked by existing repository warnings.