Repository navigation
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
ArdaTkn
force-pushed
the
feat/optional-rig
branch
from
November 19, 2026 22:10
4271b2d to
661873f
Compare
Contributor
Author
|
Rebased onto latest |
ArdaTkn
force-pushed
the
feat/optional-rig
branch
2 times, most recently
from
November 19, 2026 22:48
45d10ca to
f6e016d
Compare
SkyeAv
requested changes
Nov 19, 2026
SkyeAv
left a comment
Owner
There was a problem hiding this comment.
Thanks, @ArdaTkn! The core implementation looks good. Before merging, please:
- Rebase onto
mainand resolve theCHANGELOG.mdconflict. - Update
docs/index.md:41and the node/edgeprovided_bywording ingraph.md:32andmodels.py:1438. - Add real byte-parity and RIG-less
validate-kgxassertions, or adjust the current test claims. - Rename the stale “required RIG” test in
tests/test_models.py:47.
Targeted tests pass: 188 passed, 1 skipped.
Contributor
Author
|
Addressed all review items in
Local gates re-run and passing: |
ArdaTkn
force-pushed
the
feat/optional-rig
branch
from
November 19, 2026 23:07
f6e016d to
dd982a4
Compare
RIG publication metadata is a Translator requirement, not a graph building one; drafts and internal pipelines had to author a full RIG before anything validated (SkyeAv#274). - Graph.rig becomes optional. Without it, build-kg emits KGX only and skips compile_rig; a build-time warning notes the absent publication metadata instead of erroring. - Defined fallbacks replace every rig-derived value: graph infores comes from a new config-level infores field (valid infores CURIE; defaults to infores:tablassert), artifacts land in a new output_dir field (defaults to the current directory). Both are rejected when rig: is set, where rig.source_info.infores_id / rig.artifact_base_path stay authoritative. - Top-level infores is exempted from the legacy-keys rejection only when rig: is absent: with rig present the rejection is unchanged, and the negative legacy corpus (MOKG.yaml) still fails on description with the migration pointer. data.get(rig) (not 'rig' in data) is the guard, because validate_assignment re-runs before-validators on the default-filled dict where rig=None looks present. - uuid_namespace keeps routing through Graph.infores_id, so RIG-bearing graphs derive byte-identical namespaces and edge ids (pinned by test); RIG-less graphs with uuid_fields namespace on the fallback infores. - Tcode infores, the QC study path, and compile_graph all read the properties instead of dereferencing rig directly. Tests: RIG-less validation with both fallbacks, rig/fallback conflicts, byte-parity pin for RIG-bearing graphs, a RIG-less end-to-end build smoke (KGX emitted with fallback provided_by, no .RIG.yaml), and the updated negative corpus. Docs: graph.md required/optional tables, legacy-key wording, llms.txt summary. Closes SkyeAv#274
ArdaTkn
force-pushed
the
feat/optional-rig
branch
from
November 19, 2026 23:38
dd982a4 to
cded7c7
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #274. RIG metadata is a Translator publication requirement, not a graph-building one — drafts and internal pipelines previously had to author a full RIG (infores, terms, contributions, access locations) before anything validated.
Without
rig:the graph validates,build-kgemits KGX only and skipscompile_rig, and a build-time log warning notes the absent publication metadata. Withrig:behavior is unchanged.Fallback design (the decisions the issue asked to make explicit)
provided_by, uuid namespace)inforesfield (validated infores CURIE)infores:tablassertoutput_dirfieldBoth fields are rejected when
rig:is set — thererig.source_info.infores_id/rig.artifact_base_pathstay authoritative, so the two can never drift.One subtlety worth review attention: top-level
inforesis a legacy key (LEGACY_RIG_KEYS), so it is exempted from the legacy rejection only whenrig:is absent; the guard isdata.get("rig"), not"rig" in data, becausevalidate_assignment=Truere-runsmode="before"validators on the default-filled dict whererig=Nonelooks present. The vendored negative corpus (MOKG.yaml) still rejects ondescriptionwith the migration pointer.Byte-parity pin
uuid_namespacealready routed throughGraph.infores_id; it now resolves rig -> explicitinfores->infores:tablassert. RIG-bearing graphs derive identical namespaces and edge ids — pinned by an explicit test, per the issue's success metric.Changes
models.py:rigoptional; newinfores/output_dirfields with conflict validation;infores_id/artifact_pathproperties; guarded legacy-key check;RIGConfigdocstringlib.py:compile_graph(rig: RIGConfig | dict | None, ..., output_dir, infores); therigphase is skipped whenrigisNonecli.py: Tcode infores and the QC study read the properties; build-time warning for RIG-less graphsprovided_byfallback, no.RIG.yaml), updated negative corpus +test_graph_rejects_missing_rig_sectioninverted to the new contractgraph.mdrequired/optional tables + legacy-key wording,llms.txtsummaryLocal gate
ruff check/ruff format --check: cleanpyright: 0 errors;vulture/deptry: cleanmain(two macOS errno tests +test_real_repo_files_round_trip, already tracked by your follow-up issue)mkdocs build --strict: clean