Repository navigation
fix: commit current minified assets for source installs and verify them in CI - #2026
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Document and enforce minified asset freshness AGENTS.md, .github/workflows/pr-build-test.yml |
The guidance specifies how to regenerate and commit minified JavaScript and CSS files. After the build, the workflow checks matching minified assets, excludes assets/js/lib/**, and reports changed or untracked files. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix
Possibly related PRs
- Ultimate-Multisite/ultimate-multisite#2014: Changes JavaScript source files while excluding generated minified assets; this PR documents and checks the generated asset contract.
- Ultimate-Multisite/ultimate-multisite#2020: Changes a JavaScript source file while excluding its generated minified asset; this PR documents and checks the generated asset contract.
Merge Risk: 
Minimal · up to d0702
-
The asset freshness documentation and CI check introduce no identified merge-blocking risk.
Pre-merge checks: 
5
-
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
🔨 Build Complete - Ready for Testing!📦 Download Build Artifact (Recommended)Download the zip build, upload to WordPress and test:
🌐 Test in WordPress Playground (Very Experimental)Click the link below to instantly test this PR in your browser - no installation needed! Login credentials: |
Summary
Source (Composer
dev-main) installs serve the committed*.min.js/*.min.cssfiles directly. Onmain, 12 minified scripts did not match their sources, so such installs loaded outdated or missing JavaScript (hosting deploy for superdav42/tgc.church#1255 stopped on this before activation):checkout-provisioning,money-mask,provisioning-progress.activity-stream,checkout,command-palette,coupon-code,settings-loader,sso,thank-you,view-logs,wubox— e.g.checkout.js/thank-you.jschanged in feat(checkout): step-by-step provisioning progress with an ETA from this host's history #1985 while their.min.jsdates from GH#1805: baseline release quality gates and regenerate assets #1806.Changes:
pnpm run uglify(uglify-js 3.19.3,-c -m).pnpm run cleancssproduced no changes: all CSS is current. No source files change.pnpm run build, fail if committed minified assets differ from the regenerated ones or are missing (vendoredassets/js/lib/excluded).Verification
f829fdebandmainfor all 12.node --checkpasses for all regenerated scripts.aidevops.sh v3.39.49 plugin for OpenCode
Summary by CodeRabbit