Repository navigation
docs: key vendor backend capability matrix, and refuse an unsafe rewrap (CIP-5313) - #1541
Draft
freshtonic wants to merge 8 commits into
Conversation
🦋 Changeset detectedLatest commit: 0605831 The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
freshtonic
changed the title
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true |
freshtonic
force-pushed
the
james/cip-5313-document-key-vendor-backend-trade-offs-capability-matrix
branch
from
November 6, 2026 02:15
7ebb0fd to
5a73cdc
Compare
freshtonic
force-pushed
the
james/cip-5313-document-key-vendor-backend-trade-offs-capability-matrix
branch
from
November 6, 2026 05:10
d20b25a to
8367103
Compare
Link it from stack-kms and from each vendor crate.
Point to the full matrix in stack-kms-vendor.
Tell what stash keyset rewrap does to wrapped-mode values.
Also list the vendor crates that the auth binding compiles in.
…y (CIP-5313) A rewrap to another vendor key made the stored values unreadable.
freshtonic
force-pushed
the
james/cip-5313-document-key-vendor-backend-trade-offs-capability-matrix
branch
from
November 6, 2026 05:13
8367103 to
0605831
Compare
This was referenced Nov 6, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Top layer of the CIP-5203 stack. Implements CIP-5313.
stack-kms-vendorcrate docs, linked fromstack-kmsand every vendor crate. The Go matrix is corrected to match.skills/stash-zerokmssection, thestash-clirewrap text, the CLI READMEstash keysetsection, AGENTS.md and SECURITY.md.RewrapToAnotherKey, CLI coderewrap_refused). A new version of the same key, and any rewrap in derived mode, are still allowed.KeyVendorBackend::same_keydecides "same key" for each vendor.Read first: "## Summary for review" at the end of
docs/plans/2026-11-05-key-vendor-backends-decisions.md.