Skip to content

AIENG-379: stop resolving timezones client-side; send raw suite timestamp + agent offset - #1413

Merged
ItIsUday merged 2 commits into
v1from
AIENG-379-elapsed-build-option2-v1
Oct 28, 2026
Merged

ItIsUday merged 2 commits into
v1from
AIENG-379-elapsed-build-option2-v1

Conversation

@ItIsUday

Copy link
Copy Markdown
Contributor

Why

The CLI resolves JUnit <testsuite timestamp> timezones itself with a blanket tzlocal(). That's correct for offset-aware and genuinely-local frameworks, but wrong for "looks-naive-but-UTC" runners (jest, cypress), corrupting test_cases.created_at on non-UTC agents and breaking cross-machine elapsed-time aggregation (AIENG-379). Mirroring the framework-timezone policy in every client is unmaintainable.

What

Move timezone resolution to the server (single source of truth). The CLI now:

  • sends the raw <testsuite timestamp> string as suiteTimestamp (unresolved);
  • sends the agent's UTC offset once per record tests request (agentUtcOffset), which only the client knows and the server needs to resolve naive local timestamps.

_timestamp()/tzlocal() and the framework-TZ imports are removed — the CLI holds zero timezone knowledge. Requires the paired mothership change that accepts these fields and resolves them.

Tests

Full suite green except the pre-existing, unrelated subset failure test_maven.test_scan_test_compile_lst. Updated golden payloads to the raw-passthrough format; comparator excludes the machine-dependent agentUtcOffset.

v1-first per the two-branch process; will be forward-ported to main.

…g timezones client-side

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…void clash with ST test suite)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

@ono-max ono-max left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ItIsUday

Let's merge the PR in mothership first and merge one in CLI later.

@ItIsUday
ItIsUday merged commit 362caf4 into v1 Oct 28, 2026
14 checks passed
@ItIsUday
ItIsUday deleted the AIENG-379-elapsed-build-option2-v1 branch October 28, 2026 05:08
@github-actions github-actions Bot mentioned this pull request Oct 28, 2026
@github-actions github-actions Bot mentioned this pull request Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants