Repository navigation
fix(deps): make the weekly Dependabot cargo jobs runnable again - #2852
Merged
Merged
Conversation
turso_core prerelease requirement over a stable lock, path-dep fixtures picking up bashkit's workspace deps, and fork-only Monty deps being bumped.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 71fb4ac | Commit Preview URL Branch Preview URL |
Nov 06 2026, 01:10 AM |
Review summary — #2852 (head
|
This was referenced Nov 6, 2026
chaliy
added a commit
that referenced
this pull request
Nov 7, 2026
…rked (#2876) A fork dependency's version may now diverge from upstream Monty 1.4.0 when its Cargo.toml line carries a `bashkit fork:` marker. This resolves a contradiction between #2852 (Dependabot deliberately leaves shared deps bumpable) and #2861 (fork manifests must match upstream): a proposal for one of the nine shared crates edits the fork manifest too, so every such bump was unmergeable and would have recurred on every weekly run. Takes #2860's content with that unblocked: fancy-regex 0.20 and getrandom 0.4 in bashkit-monty, dropping a duplicate major of fancy-regex from the graph (777 -> 776 crates) and retiring the now-unused vet exemption. fancy-regex 0.20 made Captures generic over the haystack type, so two marked Captures<'_, str> edits come with it, and regex_semantics pins the Python-visible behavior 0.20 changed against what CPython prints. The loosening is bounded: markers are scoped per (table, name); adding or dropping a dependency, changing where one comes from (package, path, git, branch, rev, tag, registry) and a [patch] or [replace] table are all unmarkable; and a marker on a dependency that matches upstream is itself an error, so a note left by a re-sync cannot excuse the next bump. Supersedes #2860.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This fixes two weekly Dependabot cargo jobs that fail on every run, and stops Dependabot from bumping the Monty forks' pinned dependencies.
turso_corewas declared as"0.8.0-pre.1"while the lock held stable 0.8.3. Dependabot then treated 0.9.0-pre.2 as in range and tried a lockfile-onlycargo update --precise, which cargo rejects. The requirement is now"0.8.3", and the lock is unchanged.crates/bashkit. Dependabot follows that path and treats every workspace dep of bashkit as theirs, then aborts withInvalidUpdatedDependencies: it can't change root-owned requirements, and the optional deps are in no lockfile here. That entry nowallows only each manifest's own deps. It also usesversioning-strategy: increase, because the fixtures have no committed lockfile.bashkit-monty/bashkit-monty-typesdeclare (chore(deps): bump the rust-dependencies group with 17 updates #2848 movedruff_python_*from 0.0.14 to 0.0.20 andunicode_names2from 1 to 4, and its CI is red). Those crates are now ignored in the "/" entry, so they move only with upstream Monty. Deps the forks share with bashkit stay bumpable.New tests in
scripts/tests/test_dependabot_coverage.pypin all three: no prerelease requirement over a stable lock, anallowlist that covers each path-dep manifest's own deps, and every fork-only dep ignored.Why
These jobs fail every week, so nothing gets updated (#2848 shows the fork problem).
Before / After
Before, with the old requirement:
Dependabot logs:
Error processing turso_core (RuntimeError)andPrevious version was not provided for: 'num-bigint, pyo3' No requirements change for: 'tokio, thiserror, ...'.After: the new tests fail on the old config (5 failures) and pass on the new one. The real proof is the next weekly Dependabot run.
Risk
Cargo.lockis unchanged.allow. The test enforces this.<a href="
https://backend.blacksmith.sh/track/enable-autofix?expires=1796519405&installation_model_id=447267&pr_number=2852&ref=codesmith_pr_footer&repository=everruns%2Fbashkit&return_to=https%3A%2F%2Fgithub.com%2Feverruns%2Fbashkit%2Fpull%2F2852&signature=3668fa76ab39ca42a778231af3ad0d512bd4ae4392d39fd62962d1d35880f339"><picture><source media="(prefers-color-scheme: dark)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-light.svg"><img alt="Autofix with [code]smith" src="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark-3x.png" width="190" height="28">Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Generated by Claude Code